Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly list the algorithms this supports, e.g. RS256, RS384, RS512 #281

Closed
marvin1up opened this issue Jan 15, 2022 · 2 comments · Fixed by #284
Closed

Explicitly list the algorithms this supports, e.g. RS256, RS384, RS512 #281

marvin1up opened this issue Jan 15, 2022 · 2 comments · Fixed by #284
Labels
documentation

Comments

@marvin1up
Copy link

Describe the problem you'd like to have solved

Documentation only.

I haven't looked in the code but it seems by the library name that this would support getting signing keys as long as the alg is one of RS256, RS384 or RS512

In one documentation example, there is a setting of alg: "RS256" suggesting that is supported.

Describe the ideal solution

Add a sentence in the readme that the three algorithms RS256, RS384 or RS512 are supported (or, whatever set of alg values would work.)

Alternatives and current work-arounds

None

Additional information, if any

None
@marvin1up
Copy link
Author

OK, and I looked at the code, and find allowedSignatureAlg in config.js - so presumably this package jwks-rsa actually supports getting signing keys and there public key data for other algorithms besides "RSA" algorithms. It's worth a sentence in the README, maybe?

@kcmannem
Copy link

kcmannem commented Feb 2, 2022 •
edited
Loading

+1, on first glance its not obvious the library supports more than rsa

@adamjmcgrath adamjmcgrath mentioned this issue Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about JWK types and JWS Algorithms auth0/node-jwks-rsa
3 participants
@adamjmcgrath @kcmannem @marvin1up