Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strictSsl ignored after switch to Axios #139

Closed
paganwinter opened this issue Apr 20, 2020 · 1 comment · Fixed by #146
Closed

strictSsl ignored after switch to Axios #139

paganwinter opened this issue Apr 20, 2020 · 1 comment · Fixed by #146

Comments

@paganwinter
Copy link

node-jwks-rsa/src/wrappers/request.js

Line 24 in 26e2fa3

if (options.agentOptions || options.strictSSL) {

rejectUnauthorized is added to agentOptions only if strictSsl is true.
There is no way to rejectUnauthorized to false using the strictSsl option.
kopancek pushed a commit to kopancek/node-jwks-rsa that referenced this issue Jun 15, 2020
Fix strictSsl: false option being ignored
606ba62 
Related:
auth0#139
@kopancek kopancek mentioned this issue Jun 15, 2020
Merged
4 tasks
lbalmaceda added a commit that referenced this issue Jun 17, 2020
@lbalmaceda
Merge pull request #146 from kopancek/fix-139
ff2aeb4 
Fix #139 strictSsl: false option being ignored
@paganwinter
Copy link
Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #139 strictSsl: false option being ignored kopancek/node-jwks-rsa
1 participant
@paganwinter