-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle clock skew with leeway option #18
Comments
Update: Upon reading the openid-client docs, I discovered I can do the following: in
Would it be beneficial to respect the leeway setting as expected and set it like so? |
Merged
Fixed in |
Awesome! It seems to be working in my project. Thanks for the quick response and fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Getting this error when running from my local server:
Running on a pushed production server works as expected.
According to the Auth0 ref, we can set a leeway integer to deal with small amount of clock skew. However, this library doesn't seem to support it as an option.
I saw a commit merged earlier today that solved a similar issue with the audience option. I tried following in their footsteps by adding settings.leeway to the handlers/login.js. I see it correctly added to the url when logging in, yet I still receive the error.
Reproduction
Possibly hard to reproduce unless you manually change the time to be incorrect.
Environment
The text was updated successfully, but these errors were encountered: