Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing package.json requirement #181

Closed
mattgodbolt opened this issue Jan 23, 2021 · 3 comments · Fixed by #182
Closed

Missing package.json requirement #181

mattgodbolt opened this issue Jan 23, 2021 · 3 comments · Fixed by #182

Comments

@mattgodbolt
Copy link

Describe the problem

Installing the package and trying to require it led to a module not found:

  requireStack: [
    '/home/mgodbolt/dev/personal/ce/compiler-explorer/node_modules/express-openid-connect/lib/hooks/getLoginState.js',
    '/home/mgodbolt/dev/personal/ce/compiler-explorer/node_modules/express-openid-connect/lib/config.js',
    '/home/mgodbolt/dev/personal/ce/compiler-explorer/node_modules/express-openid-connect/middleware/auth.js',
    '/home/mgodbolt/dev/personal/ce/compiler-explorer/node_modules/express-openid-connect/index.js',
    '/home/mgodbolt/dev/personal/ce/compiler-explorer/app.js'
  ]

What was the expected behavior?

Importing the module should work.

Reproduction

Environment

  • Version of this library used: 2.2.0
  • Which framework are you using, if applicable: express
  • Other modules/plugins/libraries that might be involved: n/a
  • Any other relevant information you think would be useful:

I solved the problem by manually installing base64url with npm install.
@alexmuller
Copy link

I agree, I've also just run into this problem today, found your issue and resolved it the same way 👍

I think this was fixed by #180 and it'll need a release to npm.

@NotMyself
Copy link

This issue is also affecting our express based lab applications.

@NotMyself NotMyself mentioned this issue Jan 25, 2021
Merged
@davidpatrick
Copy link
Contributor

We will get a patch release out today with the recent fix. Thanks everybody for raising the impact visibility

@davidpatrick davidpatrick mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 2.2.1 auth0/express-openid-connect
4 participants
@NotMyself @alexmuller @mattgodbolt @davidpatrick