Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointException in OAuthManager #681

Closed
6 tasks done
MarcusCwl opened this issue Aug 2, 2023 · 2 comments
Closed
6 tasks done

NullPointException in OAuthManager #681

MarcusCwl opened this issue Aug 2, 2023 · 2 comments
Labels
bug This points to a verified bug in the code

Comments

@MarcusCwl
Copy link

Checklist

Description

Hi team

We recently found the Auth0 SDK contributing crash

Please check line 204 of OAuthManager

In the function AssertNoError
The SDK forces an optional argument errorDescription as non-null which causes the NPE.

//Helper Methods
    @Throws(AuthenticationException::class)
    private fun assertNoError(errorValue: String?, errorDescription: String?) {
        if (errorValue == null) {
            return
        }
        ...
        ...
        when {
            ...
            ERROR_VALUE_UNAUTHORIZED.equals(errorValue, ignoreCase = true) -> {
                //Should not force errorDescription non-null
                throw AuthenticationException(ERROR_VALUE_UNAUTHORIZED, errorDescription!!)
            }
           ...
           ...
        }
    }

Please help check and fix.

Reproduction

Just start Application

Additional context

We already report this issues but not get resolved.
And the number is quite high. Please help fix it asap.

Auth0.Android version

2.9.3

Android version(s)

7-13

@MarcusCwl MarcusCwl added the bug This points to a verified bug in the code label Aug 2, 2023
@poovamraj
Copy link
Contributor

@MarcusCwl this issue should be fixed in our latest version. Can you check it out and let us know if it still reproduces?

@poovamraj
Copy link
Contributor

This has been fixed in the latest version so we are closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants