Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should SocketException be considered a network exception #657

Closed
5 tasks done
bennycao opened this issue May 15, 2023 · 1 comment
Closed
5 tasks done

Should SocketException be considered a network exception #657

bennycao opened this issue May 15, 2023 · 1 comment
Labels
feature request A feature has been asked for or suggested by the community

Comments

@bennycao
Copy link
Contributor

Checklist

  • I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
  • I have looked into the API documentation and have not found a suitable solution or answer.
  • I have searched the issues and have not found a suitable solution or answer.
  • I have searched the Auth0 Community forums and have not found a suitable solution or answer.
  • I agree to the terms within the Auth0 Code of Conduct.

Describe the problem you'd like to have solved

the isNetworkError property on AuthenticationException currently defines a network error who's exception is a NetworkErrorException, UnknownHostException or SocketTimeoutException .

Should SocketException also be checked and marked as a network error ? We don't log network errors, but a lot of java.net.SocketException: Connection reset fall through and get logged.

Describe the ideal solution

SocketException considered a network error

Alternatives and current workarounds

No response

Additional context

No response

@bennycao bennycao added the feature request A feature has been asked for or suggested by the community label May 15, 2023
@poovamraj
Copy link
Contributor

@bennycao This has been fixed in this release - https://github.com/auth0/Auth0.Android/releases/tag/2.9.3. Hope this helps. Thanks for your feedback and keep it coming 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A feature has been asked for or suggested by the community
Projects
None yet
Development

No branches or pull requests

2 participants