Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitive dependency changes app's name #646

Closed
laramartin opened this issue Apr 11, 2023 · 2 comments
Closed

Transitive dependency changes app's name #646

laramartin opened this issue Apr 11, 2023 · 2 comments
Labels
bug This points to a verified bug in the code

Comments

@laramartin
Copy link

Describe the problem

We are using your library and updated to version 2.9.0.

After we created a release build, we noticed that our app name was changed to "Android Browser Helper".

We found out that Auth0 is pulling the "Android browser helper" library as a transitive dependency. This dependency was the culprit overriding the standard app name. We have our strings in a different module than the app module (it should be ok to do this!), therefore the browser helper's name was taking precedence, as they declare it in their app module.

I raised an issue here as well GoogleChrome/android-browser-helper#419

Environment

  • Version of this library used: v2.9.0
  • Other modules/plugins/libraries that might be involved: android-browser-helper
@poovamraj poovamraj added the bug This points to a verified bug in the code label Apr 26, 2023
@poovamraj
Copy link
Contributor

Hi @laramartin thanks for raising this. Looks like android-browser-helper will be fixing this issue. We can pull it in once it is fixed there. I am following the issue there. Until then I guess you can use tools:override to ensure the correct app_name is used. We will close the issue here for now. Please comment here if you have more to add and we can reopen this issue.

@laramartin
Copy link
Author

thank you for following up and for the suggestion. I should have mentioned that we ended up moving our app_name string to the app module :)

No need to reopen, we wanted to only raise awareness here in case someone else searches for this.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This points to a verified bug in the code
Projects
None yet
Development

No branches or pull requests

2 participants