-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next Auth0.Android Major release #446
Comments
Will Lock.Android still be usable with this? (Anyways, Lock.Android still needs to be jetified) |
Update: it does not.
|
Awesome news 🎉 Just noticed two things: 1. Using legacy JSON serialization dependency
2. Networking logic separated but default implementation (with dependencies) includedIt would be logical that default networking/serialization implementation would be pulled to clients only if they use it. Maybe separating two modules:
|
Lock Android and Auth0 Android are different libraries meant to be used separately. However, this SDK is an Making Lock Android stop requiring Jetifier (migrating to Android X) is a separate project that is not on the scope today. It would also mean a new major release of Lock Android. I can check with the Product team to help clarify that. |
@audkar we appreciate the feedback! I agree that Gson is old and could use some update. What we need such a library for is really for the simple use case of parsing the server responses and/or the ID token's header and payload parts, which are not too complex for this SDK at least. I think a solution that doesn't involve any third-party libraries would be ideal. I know android does have some support for that e.g. using JSONObject. About the second one, I like the separation of modules. I would like to balance overengineering this SDK vs providing good defaults. Considering one for production always uses Proguard to remove unused code/dependencies, the final package size should not be a problem if you decide to provide your own implementation of the It's our understanding that Square's OkHttp is the most used networking client on Android/Java. Square's libraries are even being used officially by Google in their codelabs, and the Android Studio IDE has official support for OkHttp in the Network Profiler tab (pictures below). I'm curious about what networking library you use typically on your apps? Or if you normally use Proguard for production builds. Let me raise these in our next Product call to evaluate making those changes. ResourcesCodelabs using Square's librariesNetwork Profiler |
Yes, most developers do use Proguard/R8. But added dependency is still pulled. That adds work to Gradle dependencies resolution, code shrinking and unnecessary dependency restriction. So in case I decide to use my own http implementation, CI server still have to pull default http implementation dependencies and code shrinker work to remove it. So 1st point (removing Gson) would be in my wishlist. 2nd point (separate networking default dependencies) is a nit picking to make great library and making sure that it will not cause problems for clients in future. |
Thanks for the explanation. One of the last changes we added this week before releasing 2.0.0 was one that could enable us in the future to safely drop Gson in favor of different implementations. While we still haven't made that decision, it's something we can now change internally without breaking our users. I appreciate you gave us prompt feedback. |
Lock Android got released this week with support for the newer SDK. SLAs got updated as well. I'm closing this now. Feel free to create a new issue if you come across any errors. |
Hello! 👋 We've been working over the past month to bring you a few improvements to the Auth0 Android SDK. Yesterday we published the first beta release for the v2 branch.
A few notable highlights the BETA introduces:
If you're coming from the previous major, you can check out the Migration Guide or dive into the updated quickstart guide here.
The release is also available both in Bintray and Maven Central.
We’d love for you to give the new SDK a try and welcome your feedback on any recommendations or issues you encounter.
Should you have any feedback or questions about the SDK, please raise an issue via GitHub.
Update Feb 11th
We've released the stable version 2.0.0.
Version v1 will continue to receive Bug & Security fixes until 5th November 2021. After that date, the only version supported will become v2.
The text was updated successfully, but these errors were encountered: