Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: auth0/Auth0.Android Loading
base: 1.27.0
Choose a base ref
...
head repository: auth0/Auth0.Android Loading
compare: 1.28.0
Choose a head ref
  • 8 commits
  • 12 files changed
  • 2 contributors

Commits on Oct 7, 2020

  1. Catch a gson JsonIOException when parsing SimpleRequest response.

    IOExceptions are already caught, but it turns out in some cases, gson actually wraps underlying IOExceptions in JsonIOExceptions (which does not extent IOException).
    
    Example stack trace:
    ```
    Fatal Exception: com.google.gson.JsonIOException: java.net.SocketTimeoutException: timeout
       at com.google.gson.internal.Streams.parse(Streams.java:62)
       at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:65)
       at com.google.gson.TypeAdapter.fromJson(TypeAdapter.java:260)
       at com.auth0.android.request.internal.SimpleRequest.onResponse(SimpleRequest.java:76)
       at com.squareup.okhttp.Call$AsyncCall.execute(Call.java:177)
       at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:764)
    
    Caused by java.net.SocketTimeoutException: timeout
       at okio.SocketAsyncTimeout.newTimeoutException(SocketAsyncTimeout.java:143)
       at okio.AsyncTimeout.access$newTimeoutException(AsyncTimeout.java:162)
       at okio.AsyncTimeout.withTimeout(AsyncTimeout.java:154)
       at okio.AsyncTimeout$source$1.read(AsyncTimeout.java:340)
       at okio.internal.RealBufferedSourceKt.commonRead(RealBufferedSourceKt.java:39)
       at okio.RealBufferedSource.read(RealBufferedSource.java:188)
       at com.squareup.okhttp.internal.http.Http1xStream$ChunkedSource.read(Http1xStream.java:439)
       at okio.internal.RealBufferedSourceKt.commonRead(RealBufferedSourceKt.java:39)
       at okio.RealBufferedSource.read(RealBufferedSource.java:188)
       at okio.internal.RealBufferedSourceKt.commonExhausted(RealBufferedSourceKt.java:49)
       at okio.RealBufferedSource.exhausted(RealBufferedSource.java:198)
       at okio.InflaterSource.refill(InflaterSource.java:112)
       at okio.InflaterSource.readOrInflate(InflaterSource.java:76)
       at okio.InflaterSource.read(InflaterSource.java:49)
       at okio.GzipSource.read(GzipSource.java:69)
       at okio.RealBufferedSource$inputStream$1.read(RealBufferedSource.java:158)
       at sun.nio.cs.StreamDecoder.readBytes(StreamDecoder.java:288)
       at sun.nio.cs.StreamDecoder.implRead(StreamDecoder.java:351)
       at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:180)
       at java.io.InputStreamReader.read(InputStreamReader.java:184)
       at com.google.gson.stream.JsonReader.fillBuffer(JsonReader.java:1291)
       at com.google.gson.stream.JsonReader.nextNonWhitespace(JsonReader.java:1329)
       at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:550)
       at com.google.gson.stream.JsonReader.peek(JsonReader.java:426)
       at com.google.gson.internal.bind.TypeAdapters$29.read(TypeAdapters.java:700)
       at com.google.gson.internal.bind.TypeAdapters$29.read(TypeAdapters.java:723)
       at com.google.gson.internal.bind.TypeAdapters$29.read(TypeAdapters.java:698)
       at com.google.gson.internal.Streams.parse(Streams.java:48)
       at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:65)
       at com.google.gson.TypeAdapter.fromJson(TypeAdapter.java:260)
       at com.auth0.android.request.internal.SimpleRequest.onResponse(SimpleRequest.java:76)
       at com.squareup.okhttp.Call$AsyncCall.execute(Call.java:177)
       at com.squareup.okhttp.internal.NamedRunnable.run(NamedRunnable.java:33)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:764)
    ```
    quibi-jlk authored and lbalmaceda committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    2b92ae3 View commit details
    Browse the repository at this point in the history
  2. Switch to a JsonParseException.

    quibi-jlk authored and lbalmaceda committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    23556a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66a4487 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f49afff View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b226366 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a419556 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. Configuration menu
    Copy the full SHA
    e29a089 View commit details
    Browse the repository at this point in the history
  2. Release 1.28.0

    lbalmaceda committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    01c64d3 View commit details
    Browse the repository at this point in the history
Loading