Makes fully compatible with Python 3 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treating it as b'' in Python 2.6+ will work, also.
BaseConnection returns byte strings, but we need to convert extracted values to native/Unicode strings in a Python 2 and 3 compatible way. The attempt here is to keep stdout as a byte string until the latest possible moment when the extracted substring is converted.
|
I've been running this well in production for a few months. Any chance of merging? Thanks! |
|
LGTM - thanks! |
|
Argh, sorry I've let this languish. This looks good to me, thanks for doing this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin is calling
exec_command()from Ansible's SSH connection plugin, which returnsb''strings. I was getting a TypeError when sshjail tried to split the byte string with a native string in Python 3. That's fixed by the first commit.The second commit ensures that values used later in a native string context are converted to native strings using Ansible's Python 2- and 3-friendly
to_text()method.