-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Lighthouse complains about 'Properly size images' for an image marked 'passed' by RespImageLint #70
Comments
Directly targeting Google Lighthouse is not something I would be extremely happy with I think. But looking at some statistics it seems that 360px is a very common with for smartphones. More than 50% of mobile traffic seems to have a resolution of 360 to 375 pixels wide. With this in mind one could argue that the threshold for screen sizes from 360 to 375 should be set very low because of the huge number of users that will have exactly this screen resolution. So checking for 360 and 375 (with @2x) using a lower threshold could be a good solution that works for everybody and is also closer to what Lighthouse does. What do you think? |
I think your assessment would be a very sensible approach. |
Following up on #62 (comment), I wanted to document an example of an image that Google Lighthouse is still complaining about, even though it's marked 'passed' by the bookmarklet. I don't know that we'll ever want to solve it given GoogleChrome/lighthouse#11593 (comment), but capturing for reference.
Here is the image's markup:
On the Moto G4, here's how the image appears:
The text was updated successfully, but these errors were encountered: