Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin nightly version to 2018-05-16 #3

Merged

Conversation

bfritz
Copy link
Contributor

@bfritz bfritz commented Jul 14, 2018

Build is broken with latest nightly due to panic_fmt removal:

~/.cargo/registry/src/github.com-1ecc6299db9ec823/panic-abort-0.1.1/src/lib.rs:25:1
   |
25 | #[lang = "panic_fmt"]
   | ^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `panic_fmt`

Upgrading to newer panic-abort bumps into proc-macro2 issues described in rtic-rs/rtic-syntax#7 .

Stumbled onto this when investigating a build failure for #2. Affected #1 (comment) too.

Build is broken with latest nightly due to [panic_fmt removal]:

    ~/.cargo/registry/src/github.com-1ecc6299db9ec823/panic-abort-0.1.1/src/lib.rs:25:1
       |
    25 | #[lang = "panic_fmt"]
       | ^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `panic_fmt`

Upgrading to newer panic-abort bumps into proc-macro2 issues
described in rtic-rs/rtic-syntax#7 .

Stumbled onto this when investigating a [build failure] for atsamd-rs#2.

[panic_fmt removal]: https://users.rust-lang.org/t/psa-breaking-change-panic-fmt-language-item-removed-in-favor-of-panic-implementation/17875
[build failure]: https://travis-ci.org/wez/atsamd21-rs/builds/403798265#L570
@djmcgill
Copy link
Contributor

djmcgill commented Jul 14, 2018

I would prefer a solution that removes RTFM from the metro_m0 examples crate - I'm not sure it's best to tie this entire library to an old nightly because of one example. This would also block this library from moving to stable (if desired).

@bfritz
Copy link
Contributor Author

bfritz commented Jul 15, 2018

I was thinking of this as a stop-gap to fix CI (see #2) and make it less confusing for newcomers until either RTFM can be fixed or, as you said, removed from the examples. But I totally understand where you are coming from.

@bfritz bfritz closed this Jul 15, 2018
@bfritz bfritz reopened this Jul 15, 2018
@rubberduck203
Copy link

@bfritz thanks for posting the workaround.
This definitely was confusing to me today.

@wez
Copy link
Member

wez commented Aug 23, 2018

Thanks for this; I want to unblock using more recent nightly builds so that we won't need to pin back. I've taken a stab at that in #4 and would appreciate your input to resolve a linker error.

@wez
Copy link
Member

wez commented Aug 23, 2018

I'll merge this in the meantime; thanks!

@wez wez merged commit 6640d63 into atsamd-rs:master Aug 23, 2018
kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
Build is broken with latest nightly due to [panic_fmt removal]:

    ~/.cargo/registry/src/github.com-1ecc6299db9ec823/panic-abort-0.1.1/src/lib.rs:25:1
       |
    25 | #[lang = "panic_fmt"]
       | ^^^^^^^^^^^^^^^^^^^^^ definition of unknown language item `panic_fmt`

Upgrading to newer panic-abort bumps into proc-macro2 issues
described in rtic-rs/rtic-syntax#7 .

Stumbled onto this when investigating a [build failure] for atsamd-rs#2.

[panic_fmt removal]: https://users.rust-lang.org/t/psa-breaking-change-panic-fmt-language-item-removed-in-favor-of-panic-implementation/17875
[build failure]: https://travis-ci.org/wez/atsamd21-rs/builds/403798265#L570
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants