Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Bug about Major compaction and Minor Compaction in copy cat #252

Open
txm119161336 opened this issue Oct 25, 2016 · 1 comment
Open

Bug about Major compaction and Minor Compaction in copy cat #252

txm119161336 opened this issue Oct 25, 2016 · 1 comment

Comments

@txm119161336
Copy link

Hi Jordan,

currently ,the major compaction and minor compaction are running respectively, which means ,by coincidently, maybe they will run at the same time, there is a step by which we can change the
the segments list ,like segmentlist.put(); if the minor compaction do this step after the major compaction,
maybe the major compacted segment will be discarded.

@kuujo
Copy link
Member

kuujo commented Feb 9, 2017

Have you seen them run at the same time?

The current logic uses the previous compaction's CompletableFuture to start the next compaction afterwards:
https://github.com/atomix/copycat/blob/master/server/src/main/java/io/atomix/copycat/server/storage/compaction/Compactor.java#L191-L194

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants