Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

endPosition argument #79

Closed
Thom1729 opened this issue Jun 1, 2018 · 2 comments
Closed

endPosition argument #79

Thom1729 opened this issue Jun 1, 2018 · 2 comments

Comments

@Thom1729
Copy link

Thom1729 commented Jun 1, 2018

I'm using node-oniguruma to port the Sublime Text syntax highlighting engine to JavaScript. Sometimes, the engine has to restrict scanning to a prefix of the current line (because an escape pattern has been matched). In that situation, I am explicitly slicing the string. It would be better to instead pass an endPosition argument to findNextMatchSync. Oniguruma supports this, but node-oniguruma does not expose the feature, but always passes the end of the string as the end position.

@zikaari
Copy link

zikaari commented Jul 9, 2018

Sounds totally amazing and would love to see it implemented.

I would love to bring this to node-oniguruma's WebAssembly port, onigasm once it's accepted here.

@rsese
Copy link

rsese commented Apr 11, 2019

Thank you again for the suggestion; closing per the comment in #90 (comment)

@rsese rsese closed this as completed Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants