-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Developer Readme #3068
Comments
Just to add on to this, if we end up removing sections like the Nix installation guide, security sandbox, and shortening others, that could make room to expand on things in other places. Particularly, I'm not a huge fan of linking to |
If I understood it correctly, you suggest keeping Or are you saying that we should have no instructions at the top of the |
You understood correctly. The |
@hgluka shall I assign you, or shall I do this? |
Let me just check first. The idea is this:
If I'm not missing anything, then yeah, I can do it. |
OK, great :-) |
Here's a thought. The target audience of developer's installation are package managers maintainers. Guix users can install Nyxt via the first instruction available at |
Regarding "Contributing": this one should rather be a CONTRIBUTING file at the repository root, so that we conform to the established norms set by other projects, and so that Github suggests our contributors read this. Moving "Programming conventions" there feels like a right move too. |
Yes, but unfortunately Nyxt does not work with firejail :-( |
In short, do we want to:
Section "Standard developer's installation" feels a bit odd in the sense that it repeats much of the installation process mentioned in the INSTALL file. Maybe it's purpose is to serve as a more in-depth reference that complements INSTALL and nyxt/documents/SOURCES.org. I think it goes too much in depth nonetheless. For instance, when it describes how to install dependencies such as webkitgtk in different GNU/Linus distributions. Package maintainers need to know the build of materials, and the rest they can figure out.
I think we should erase all references to quicklisp. We already mention that relying on it is discouraged. The git submodules render quicklisp useless. Since it's a tool that CL programmers tend to use, I think a single note somewhere mentioning why we don't rely on it suffices.
Structure-wise, the first-level contents should be (in order):
Maybe 1. and 2. should be swapped.
I suggest getting rid of "Run Nyxt in a security sandbox". nyxt.scm already mentions how to run in a container already. Does anyone actually use Firejail?
The text was updated successfully, but these errors were encountered: