Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI build job targeting the same Go version as listed in this project's go.mod file #214

Open
atc0005 opened this issue Mar 23, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@atc0005
Copy link
Owner

atc0005 commented Mar 23, 2023

The current version listed in the go.mod file is Go 1.14:

go-teams-notify/go.mod

Lines 9 to 11 in cc08182

module github.com/atc0005/go-teams-notify/v2
go 1.14

Yet as I write this, we're currently building/linting/testing using the most recent stable version of Go (1.20.2) and the most recent oldstable version of Go (1.19.7).

The original maintainer added their go.mod file in 2020 when Go modules support was still fairly new and around the time that Go 1.14 was first released (2020-02-25).

This project still lists support for Go 1.14 (and doesn't use newer Go features) since the assumption is that library consumers still need to build using older Go versions. This is likely a false assumption.

Until an audit can be performed to confirm one way or the other, we should add a separate CI build/test job using the last available Go version from the series referenced by the go.mod file.

Depending on what this project's dependencies require (currently stretchr/testify), we may be forced to re-evaluate the minimum Go version supported.

@atc0005 atc0005 added this to the Future milestone Mar 23, 2023
@atc0005 atc0005 self-assigned this Mar 23, 2023
@atc0005
Copy link
Owner Author

atc0005 commented Mar 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant