-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0.0 REVIEW] Use JSON Schema Draft 07 as the default schema #212
Comments
|
Awesome!! 🎉 And congrats for your first contribution on JSON Schema, Phil. |
@philsturgeon I'm going to (almost) follow your suggestion here: OAI/OpenAPI-Specification#1977. However, and since tooling is not yet ready for Draft-08, AsyncAPI is going to adopt a superset of Draft-07 as the default schema, and the parser will provide a "translator" from current OpenAPI schemas. Thanks for the work you did there. It helped clarify the current scenario. |
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
After playing a lot these days with AsyncAPI 2.0.0-rc1, I realized most of the pain comes from having the OpenAPI schema as the default. We want to keep supporting OpenAPI schemas but there's no need to make it the default choice.
There's only one thing that worries me and it's the lack of a deprecation property in Draft 07. However, @philsturgeon is working on it and will probably make it for Draft 08. As per
discriminator
andexternalDocs
, they can just be extensions in the form ofx-discriminator
andx-external-docs
. Same fordeprecated
in the meantime, it can be done usingx-deprecated
.@handrews do you have a list of changes (or potential changes) for Draft 08? I've seen this but I'd like to know if upgrading the AsyncAPI default schema from Draft 07 to Draft 08 will be a breaking change. Or put it another way, are there breaking changes in Draft 08 compared to Draft 07?
The text was updated successfully, but these errors were encountered: