Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect rule deprecation in JSON schema #12906

Closed
wants to merge 1 commit into from

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Aug 15, 2024

Summary

This PR updates our RuleSelector schema generator to reflect a rule's deprecation status in the schema.

Test Plan

Used Zed

# :schema /home/micha/astral/ruff/ruff.schema.json

preview = true
extend-include = ["*.ipynb"]

output-format = "text"

[format]
preview = true
quote-style = "double"
indent-style = "space"
skip-magic-trailing-comma = false
line-ending = "auto"

[lint]
select = ["ALL", "E99"]

But neither VS code nor Zed (Both use even better toml) use any specific formatting for deprecated rules :( So not sure if it is worth it.

@zanieb zanieb self-requested a review August 15, 2024 14:14
Copy link

codspeed-hq bot commented Aug 15, 2024

CodSpeed Performance Report

Merging #12906 will improve performances by 10.78%

Comparing reflect-rule-deprecation-in-json-schema (2312dc5) with main (b9da316)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main reflect-rule-deprecation-in-json-schema Change
linter/all-with-preview-rules[numpy/globals.py] 911.3 µs 822.6 µs +10.78%

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@AlexWaygood AlexWaygood changed the title Reflect rule deprection in JSON schema Reflect rule deprecation in JSON schema Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant