Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting in code frames and diffs #10835

Open
MichaReiser opened this issue Apr 8, 2024 · 4 comments
Open

Syntax highlighting in code frames and diffs #10835

MichaReiser opened this issue Apr 8, 2024 · 4 comments
Labels
cli Related to the command-line interface wish Not on the current roadmap; maybe in the future

Comments

@MichaReiser
Copy link
Member

We should consider highlighting code frames and diffs.

I think a good first step would be to implement semantic highlighting into ruff server that, given a string, emits a description of the highlighting. The codeframe and diff rendering can then reuse the same infrastructure to implement.

This is related to astral-sh/ruff-lsp#237

@MichaReiser MichaReiser added cli Related to the command-line interface wish Not on the current roadmap; maybe in the future labels Apr 8, 2024
@Zander-1024
Copy link

This is really important. I hope this feature can be implemented soon.

@SnirShechter
Copy link

I'd very much like to see that.

Currently when using VSCode, you must use the Python extension for syntax highlighting so ruff can't completely replace it and they be used together (which kind-of misses the point of being fast when you must use another extension that's slow).

@danny-huang-openfind
Copy link

While this feature is also important to me, I believe a linter shouldn't be concerned with it. Ruff should focus on "making every kind of linter work within its scope," rather than "trying to solve everything."

@oramirite
Copy link

oramirite commented Nov 23, 2024

I think ruff's leap into automatic formatting - and doing a damn good job of it - kinda broke that seal already. I think the desire to see this feature stems from that. Completing the "triad" of core tools that would allow for ruff to be a complete replacement for the multiple plugins we currently need, would be a Godsend.

I'd very much enjoy having centralized configuration if these elements in ruff so I can fully replace the Intelligence stuff (it can be very slow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to the command-line interface wish Not on the current roadmap; maybe in the future
Projects
None yet
Development

No branches or pull requests

5 participants