Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribution Map Encoder Ordering #79

Closed
whitead opened this issue Feb 22, 2022 · 1 comment
Closed

Attribution Map Encoder Ordering #79

whitead opened this issue Feb 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@whitead
Copy link
Contributor

whitead commented Feb 22, 2022 •
edited

The attribution map from encoding is sorted by SMILES token, which makes it difficult to align SELFIES string with the attribution map. See comment here.

I will work on this when I have some time 😅
@MarioKrenn6240 MarioKrenn6240 added the enhancement New feature or request label Mar 28, 2022
@whitead whitead mentioned this issue May 7, 2022
Merged
@whitead
Copy link
Contributor Author

whitead commented May 13, 2022

Fixed by #84

@whitead whitead closed this as completed May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitead @MarioKrenn6240