Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Cancellation in Streamed results #481

Closed
analogrelay opened this issue May 23, 2017 · 4 comments
Closed

Cancellation in Streamed results #481

analogrelay opened this issue May 23, 2017 · 4 comments

Comments

@analogrelay
Copy link
Contributor

We need to review how cancellation works in Streamed results. If the connection terminates, we need to be able to stop enumerating the sequence the user gave us, and ideally signal cancellation back to it in order to cancel any other async operations.

On a similar note, we may want to add support for passing a CancellationToken in to a Hub method.

@grahamehorner
Copy link

@anurse +1 for passing a CancellationToken into a hub method. question would this be a token from a client or a server side token? could this be used by an administrator to terminate badly behaved SignalR hub streaming methods? or place a upper limit on time of execution etc.

@moozzyk
Copy link
Contributor

moozzyk commented Jun 9, 2017

Need to expose a CancellationToken to the hub in some way. Needs some design/discussion.

@davidfowl
Copy link
Member

On a similar note, we may want to add support for passing a CancellationToken in to a Hub method.

I think we should just expose it as a property on the Context instead of being a parameter.

@analogrelay
Copy link
Contributor Author

analogrelay commented Jun 28, 2017

Agreed. If we put it as an argument it would be confused with something the client could control.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants