Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create install directory with mkdir -p #1563

Merged
merged 2 commits into from
May 31, 2023

Conversation

vespian
Copy link
Contributor

@vespian vespian commented May 28, 2023

Summary

Issue with jq pluging being moved showed an issue in asdf itself - an empty download dir can be created:

dev@pr-mr-test:~/$ tree /home/dev/.asdf/downloads/
/home/dev/.asdf/downloads/
├── jq
│   └── 1.6

This was causing asdf to fail with cryptic message:

mkdir: cannot create directory ‘/home/dev/.asdf/downloads/jq/1.6’: File exists

This MR fixes that.

@vespian vespian requested a review from a team as a code owner May 28, 2023 19:48
@hyperupcall
Copy link
Contributor

hyperupcall commented May 28, 2023

LGTM! Surprised that this flag wasn't already present.

(waiting on someone else with merging permissions to merge)

@jthegedus
Copy link
Contributor

jthegedus commented May 31, 2023

I too am surprised this wasn't already present, thanks!

@hyperupcall I appreciate your reviews, really gives myself & @Stratus3D more confidence having more eyes on this. We've both been busy recently so this helps greatly! 🙏

@jthegedus jthegedus changed the title Make creating install folder robust fix: create install directory with mkdir -p May 31, 2023
@jthegedus jthegedus merged commit d6185a2 into asdf-vm:master May 31, 2023
@zoeytruong
Copy link

Thank you for fixing this. Can this merged PR go into the next release? The current release v.0.11.3 does not have this fix. I will really appreciate your help.

@hyperupcall
Copy link
Contributor

@zoeytruong Yes! It's not in v0.11.3, but it's slated for inclusion in v0.12.0. The only issue that's really blocking the release is #1550, but #1560 should be merged relatively soon. Once it's merged I think the asdf team will make their next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants