fix!: Remove files containing only asdf wrapper functions
#1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6928c9
to
88e3270
Compare
asdf wrapper functionsasdf wrapper functions
|
This is great! |
willnorris
added a commit
to willnorris/dotfiles
that referenced
this pull request
May 21, 2023
Previously, loading ASDF_DIR/asdf.sh rewrote ASDF's placement in PATH, which required only loading it in root shells, and loading ASDF_DIR/lib/asdf.sh in subshells. asdf reworked asdf.sh in asdf-vm/asdf/#1480 and asdf-vm/asdf#1521 and removed ASDF_DIR/lib/asdf.sh in asdf-vm/asdf#1525, which makes this workaround no longer effective. Instead, manually add ASDF_DIR/bin and ASDF_DATA_DIR/shim to PATH directly in root shells and load ASDF_DIR/asdf.sh in all shells (since it no longer messes with PATH).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To improve consistency with Nushell, Elvish, and PowerShell Core, this moves the wrapper functions for Fish and Bash/Zsh/POSIX Shell to their respective entrypoints.