Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nushell #1355

Merged
merged 6 commits into from
Dec 12, 2022
Merged

Conversation

fwfurtado
Copy link
Contributor

Summary

Adds support for nushell with completions.

Closes: #745

@fwfurtado fwfurtado requested a review from a team as a code owner October 20, 2022 13:01
@fwfurtado fwfurtado changed the title Add support for nushell feat: Add support for nushell Oct 20, 2022
@fwfurtado fwfurtado changed the title feat: Add support for nushell chore: Add support for nushell Oct 20, 2022
@jthegedus jthegedus changed the title chore: Add support for nushell feat: support nushell Dec 12, 2022
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Tested locally and works great. Thanks!

@jthegedus
Copy link
Contributor

I think next steps with this is to run similar tests as we have with the other shells. /test/asdf_elvish.bats etc

@jthegedus jthegedus merged commit 274a638 into asdf-vm:master Dec 12, 2022
@Stratus3D
Copy link
Member

Thanks for the PR @fwfurtado ! Thanks for merging @jthegedus !

hyperupcall pushed a commit to fox-forks/asdf that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for nushell
3 participants