Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\e[2m not working properly ? #66

Closed
lonnywong opened this issue Jan 27, 2024 · 3 comments
Closed

\e[2m not working properly ? #66

lonnywong opened this issue Jan 27, 2024 · 3 comments

Comments

@lonnywong
Copy link

Describe the bug
Check asciinema/asciinema-player#52

To Reproduce
Steps to reproduce the behavior:

  1. Run the script and covert it to gif:
#!/bin/bash

printf "\n"
printf "    _   __                           __   \e[2m______      _       __ \e[0m\n"
printf "   / | / /___  _________ ___  ____ _/ /  \e[2m/ ____/___ _(_)___  / /_\e[0m\n"
printf "  /  |/ / __ \/ ___/ __ ´__ \/ __ ´/ /  \e[2m/ /_  / __ ´/ / __ \/ __/\e[0m\n"
printf " / /|  / /_/ / /  / / / / / / /_/ / /  \e[2m/ __/ / /_/ / / / / / /_  \e[0m\n"
printf "/_/ |_/\____/_/  /_/ /_/ /_/\__,_/_/  \e[2m/_/    \__,_/_/_/ /_/\__/  \e[0m\n"
printf "\n"

Expected behavior
The gif works same as asciinema player.

Versions:

  • OS: macOS 14.2.1
  • agg: 1.4.3 89c9576
@ku1ik
Copy link
Contributor

ku1ik commented Feb 14, 2024

Thanks. Faint attr support is missing indeed, but should be rather straightforward to add it.

@ku1ik ku1ik closed this as completed in 530bda9 Oct 23, 2024
@ku1ik
Copy link
Contributor

ku1ik commented Oct 23, 2024

Faint attr support is now available in the default (fontdue) renderer. This will be released with the next version, very soon.

We'll be able to also implement that in the alternative renderer (resvg) once opacity is supported on tspan elements in resvg (linebender/resvg#414).

@ku1ik
Copy link
Contributor

ku1ik commented Oct 27, 2024

So, I released 1.5.0 with this improvement (amongst many others). I made resvg renderer a default, as it gives overall better results (better font rendering, emoji, etc). Faint attr is not supported in it, but you can run agg --renderer fontdue ... to use fontdue renderer, which supports faint rendering.

https://github.com/asciinema/agg/releases/tag/v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants