Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rewrite file if it already exists #428

Closed
wants to merge 1 commit into from

Conversation

sransara
Copy link
Contributor

@sransara sransara commented Aug 13, 2023

Closes: #431

Do not rewrite file if it already exists in Node environment.

This matches the behavior implemented in Ruby:

@sransara sransara changed the title Do not write file if it already exist Do not rewrite file if it already exists Aug 13, 2023
@sransara
Copy link
Contributor Author

Seems this issue got fixed in this commit: 9eb59c3

@sransara sransara closed this Jul 14, 2024
@sransara sransara deleted the dont-rewrite-if-exists branch July 14, 2024 13:08
@ggrossetie
Copy link
Member

Good to know 👍🏻
Sorry for the delay I wasn't sure if this fix had unintended effects or not since this extension is used in many different environments/use cases.

@sransara
Copy link
Contributor Author

All good. I understand. Thanks for all your work in the asciidoctor.js ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files get overwritten with their own content when they already exist
2 participants