Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support diagrams.net (draw.io) #392

Closed
JkbLskw opened this issue Sep 8, 2022 · 4 comments
Closed

Support diagrams.net (draw.io) #392

JkbLskw opened this issue Sep 8, 2022 · 4 comments
Labels
👶 good first issue Good for newcomers 🍩 enhancement New feature or request 👋 help wanted

Comments

@JkbLskw
Copy link
Contributor

JkbLskw commented Sep 8, 2022

In the kroki documentation, the diagram type "diagrams.net" (draw.io) is specified as experimental.
Unfortunately I couldn't find an issue regarding adding this diagram type to the asciidoctor-kroki extension.

Are there any plans for this?

@ggrossetie ggrossetie added 🍩 enhancement New feature or request 👋 help wanted 👶 good first issue Good for newcomers labels Sep 11, 2022
@ggrossetie
Copy link
Member

Sure, we can add it.
Feel free to submit a pull request to add diagramsnet support.

We should also mention in the README that diagrams.net is not available on https://kroki.io.

@JkbLskw
Copy link
Contributor Author

JkbLskw commented Sep 13, 2022

Since kroki.io support is missing, I couldn't write a test for converting diagramsnet diagram to an image.

I only tested it locally with my own kroki server. Should I post the test result to this issue?

@JkbLskw
Copy link
Contributor Author

JkbLskw commented Sep 13, 2022

I misunderstood the tests. No real connection to kroki.io is created at all.
I added the test to convert a diagrams.net diagram to an image.

@FWiesner
Copy link

Hello @Mogztter. We would love seeing a new release cut with this change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👶 good first issue Good for newcomers 🍩 enhancement New feature or request 👋 help wanted
Projects
None yet
Development

No branches or pull requests

3 participants