-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0 compilation warnings/compilation output noise on Windows MSVC #5114
Comments
add /Zc:__cplusplus to c++ command line additional options |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
. |
That smells like some issue in the cmake file. There's no such warning when building with as for
You'll notice that this is handled by only using that typedef if https://devblogs.microsoft.com/cppblog/msvc-now-correctly-reports-__cplusplus/ |
It is indeed an issue with CMake (as reported here: https://gitlab.kitware.com/cmake/cmake/-/issues/18317). It can be fixed by adding |
I no longer get the I submitted #5336 to fix the warning flags override warnings by setting @arvidn I promise I have not forgotten about my other Actions PR. The new information in this post turned this into low-hanging fruit that I'm able to pick immediately, as it turns out that it is not contingent on a refactoring to use more |
Silly me, I was not actually passing |
This has been addressed by #5336. |
libtorrent version (or branch)
v2.0.0
platform/architecture
MSVC x64
compiler and compiler version
Libraries/tools:
please describe what symptom you see, what you would expect to see instead and
how to reproduce it.
Follow up to #5111 (comment) and #5111 (comment); compilation is successful but there are some warnings/excessive compilation output noise. Not sure what is the impact/severity of these warnings in practical terms, but they could be fixed.
CMAKE_CXX_STANDARD
:Config command:
Build output (release build):
(Note the
possible loss of data
warnings and the output noise fromcl : Command line warning D9025 : overriding '/W3' with '/W4'
. Pretty sure the latter can be fixed by usingtarget_compile_options()
instead ofadd_compile_options()
to set/W4
. If no one tackles this in the meantime, I'll give it a shot in the near future.)Click to show
-DCMAKE_CXX_STANDARD=17
in the configure command line:Build output (release build):
(Note the very noisy warnings about C++17 deprecations.)
Click to show
Warnings in
Debug
builds are identical.The text was updated successfully, but these errors were encountered: