-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using poetry for packaging #26
Comments
How does poetry make it easier to contribute? I'm really curious to know!! That's the only reason I would consider to changing. How, and what would you contribute to ideas if I were to switch to using poetry? As for your other points: As a maintainer of many projects, none of which use poetry, I have a set up that works well for me. You mention that it "simplifies publishing"; since I am the one that publish ideas (and my other packages), how would it simplify my current workflow which simply involves executing a single .bat file (on Windows), which I copy from existing project when I start a new one. I don't need to install anything external (like poetry). Popularity: in 20 years of Python programming, I have seen many "popular" tools come and go. Migrating to using a new tool require a time investment which is often counterproductive. So, being "popular" is not a winning argument for me. However, there might very well be some valid reasons as to why it is popular, which could be worth investing some of my time in learning how to use poetry. |
I completely agree that popularity is not a valid argument. And neither is the workflow if you already have the one that works. As a contributor, I feel like running Personally, I love what you've accomplished with this project and I also like to discover weird magics that can be used within python. I am most likely not going to be an active contributor of examples (besides my own projects such as pysh and rupython). However, I am all in to add more features and do some refactoring. |
@Ovsyanka83 I will try to find some time to read up on poetry this week and see if it might work for me. One thing I do for many of my projects is to set up different virtual environments for different Python versions (sometimes more than one for a given Python version: for example, to test with IPython) and I have simple batch files to switch environment, run tests in one (or all environment), etc. It works well for me, but I do recognize that it is not as simple as doing |
Your workflow sounds really similar to what tox does. There are packages that interface poetry with tox but three more dependencies sounds a little too much of an addition to your workflow :) |
True story: I passionately abhor In other words, none of these claims are factually accurate:
Instead, everyone who hates
PDM Master Race: let's do this. Just kidding! I still use |
@leycec , let's go through your claims in order.
both flit and pipenv have been released way earlier than poetry
It may have been the case in the past. Now poetry has moved on to get_poetry.py and is moving to install_poetry.py which seek to remediate many issues from get_poetry.sh.
How is that a problem? It's an incredibly common pattern to split complex applications into multiple simpler applications with dependencies. It does not make them harder to install in any way
poetry on arch linux and its derivatives is installable using python-poetry package through a single command. Every other distribution has a different default system but on every single one of them install_poetry.py, pip and pipx installations for poetry are available and easily usable. Moreso, there are many examples of python software that is unavailable as a regular system package and is only installable through PyPi -- I do not see any issues with that.
I do not see how "simplifies publishing", "is a bit more readable", and "is really popular" claims are disproved by any of your points. Even if everything you've said is true, which it isn't, none of my claims are affected. You have not touched its popularity or readability. And your claim about poetry being hard to install does not affect the simplification of publishing packages.
How is that the case? Could you provide any proof at all that all other managers are less standards-compliant than pdm? In fact, the only standard PDM supports that Poetry doesn't is PEP 582 which is still a draft. So basically you are recommending to use a tool that is based on a standard that hasn't even been finished yet, i.e. it could change in its entirety and all of the developers using PDM will be affected. How is that a good thing?
The author of FastAPI, Sebastian Ramirez, has used flit for both FastAPI and Typer. However, he himself switched to poetry with his SQLModel and has publicly recommended to start new projects using poetry. |
While there might be some advantages in moving to using poetry or some other similar tool, I've decided to close this issue as I'm not ready to invest the time to change my setup. I may try to use it when I start a new project and will use the experience to see if I should use poetry with Thank you for the original suggestion, which I will keep in mind. |
Reopening as I plan to use this project as a test case for poetry. See also #34 |
With poetry, it's slightly easier to start contributing to ideas. It also simplifies publishing, is a bit more readable, and really popular in community right now.
The text was updated successfully, but these errors were encountered: