Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DynamoRIO/dynamorio Loading
base: master
Choose a base ref
...
head repository: arizvisa/dynamorio Loading
compare: master-vs2015
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 9 files changed
  • 1 contributor

Commits on Nov 11, 2016

  1. Small code fixes here and there to get VS2015 to compile ok with non-… 

    …fatal warnings

libutils/utils.c:
    Repaired an incorrect format-string as VS2015 assumes that your
    format is always wchar_t when calling the wchar_t version of
    a func.

tools/DRstats/DynamoRIOView.cpp:
    Spaced out some pre-processor macros as VS2015 made contiguous
    string literals illegal.

core/win32:
    Commented out all the fmt-string funcs that ntdll_imports{,_x64}.def
    exports because VS2015 will now inline them and so the linker should
    never see them.

    Wrapped the alias of snprintf to _snprintf and the include of
    stdio.h in a conditional macro based on the compiler version.
    This is due to this function being inlined in VS2015.
    @arizvisa
    arizvisa committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    6d34de8 View commit details
    Browse the repository at this point in the history

  2. Modifications to CMakeLists.txt scripts to include the crt fragments … 

    …which Microsoft introduced in Visual Studio 2015.

CMakeLists.txt:
    Disabled the cflag that treats a warning as a fatal error.

    Added legacy_stdio_definitions.lib to the various targets
    that use fmt-string funcs as imports.

    Fixed what seems to be a type-o when trying to link with
    ${WIN32_C_LIB}.

    Added missing libraries that are required by the crt.

make/DynamoRIOConfig.cmake.in:
core/CMakeLists.txt:
tools/CMakeLists.txt:
    Added the missing libraries that are required by the crt.
    @arizvisa
    arizvisa committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    c4c474d View commit details
    Browse the repository at this point in the history
Loading