Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: avd-lab-guide.md - simplify the expression used to set LABPASSPHRASE #148

Closed
mjbear opened this issue Mar 25, 2024 · 3 comments
Closed

Docs: avd-lab-guide.md - simplify the expression used to set LABPASSPHRASE #148

mjbear opened this issue Mar 25, 2024 · 3 comments

Comments

@mjbear
Copy link
Contributor

mjbear commented Mar 25, 2024 •
edited

Hello Arista Engineering people,

Mr. T asked me to put in issues before I open up PRs. I fully intend to open up PRs once suggestions are agreed upon. 😎

In both avd-lab-guide.md and cicd-basics.md there is an expression (piped shell commands) used to retrieve the LABPASSPHRASE from config.yaml. I have a suggestion that simplifies it greatly to exclusively an awk command.

Are you good with me submitting this as a PR?

Thank you!
This was referenced Mar 25, 2024
Closed
Closed
@JulioPDX
Copy link
Collaborator

Oh yeah, that shortcut is not set in stone. Anything to simplify process is a good thing!

@mjbear mjbear mentioned this issue Mar 26, 2024
Merged
@mjbear
Copy link
Contributor Author

mjbear commented Mar 26, 2024

Submitted PR #152

@JulioPDX
Copy link
Collaborator

Fixed in #152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JulioPDX @mjbear