Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggesting to add a small section explaining the prod.yml #125

Closed
daniel1820815 opened this issue Jan 17, 2024 · 1 comment · Fixed by #144
Closed

Suggesting to add a small section explaining the prod.yml #125

daniel1820815 opened this issue Jan 17, 2024 · 1 comment · Fixed by #144
Assignees
@JulioPDX

Comments

@daniel1820815
Copy link
Contributor

Hi there! I was going through the CICD Basics workshop and I would like to suggest adding a small section explaining the prod.yml for GitHub Actions similar to the part about the dev.yml.

It could be before or after the following part in my opinion:

At this point, this will kick off our second workflow (prod.yml) against the main branch. This workflow will build and deploy our updates with CVP.

Then it would be clearer (at least for me) how GitHub Actions triggers CVP and creates tasks there. After checking the prod.yml file it was clear but I thought it's missing in the workshop. Other than that great job!
@JulioPDX
Copy link
Collaborator

JulioPDX commented Mar 1, 2024

Apologies for the late reply and thank you for the feedback. The team will ramp back up and knockout these issues in the coming weeks. 👍🏾

@JulioPDX JulioPDX self-assigned this Mar 13, 2024
@JulioPDX JulioPDX mentioned this issue Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulioPDX JulioPDX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding explanation on the prod actions file JulioPDX/avd-workshops
2 participants
@daniel1820815 @JulioPDX