-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider renaming 'naive()' to 'as_naive()' #61
Comments
Ah, I missed the note. The diagram definitely helps. |
Correct, "losing information" is not the right wording. "loses position on the timeline" is perhaps the best way to describe |
I've created a follow-up for visualizing classes and their conversions. This includes rationale for the seemingly inconsistent naming. See #69. The current issue is about the specific method, which will not be changed. Closed. |
A very minor observation, but other conversion functions have the form:
as_utc()
as_offset
as_zoned()
as_local()
But conversion to
NiaveDateTime
is:naive()
Consider changing this to
as_naive()
for consistency.The text was updated successfully, but these errors were encountered: