Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-Emissary executors #7829

Closed
4 tasks done
Tracked by #7964
alexec opened this issue Feb 8, 2022 · 15 comments
Closed
4 tasks done
Tracked by #7964

Remove non-Emissary executors #7829

alexec opened this issue Feb 8, 2022 · 15 comments

Comments

@alexec
Copy link
Contributor

alexec commented Feb 8, 2022

@terrytangyuan
Copy link
Member

This would depend on resolving any limitations of the Emissary executor.

@alexec
Copy link
Contributor Author

alexec commented Feb 9, 2022

I think we can and should remove docker, k8sapi, and kublete executors. That would leave pns and emissary.

@terrytangyuan
Copy link
Member

Sounds good. I can start with those.

@alexec
Copy link
Contributor Author

alexec commented Feb 9, 2022

I'd hold off for a few months. I don't think we want this until maybe v3.5.

@alexec alexec added the v3.5 label Feb 9, 2022
@blkperl
Copy link
Contributor

blkperl commented Feb 14, 2022

Wouldn't the removing part need to be done in a 4.0 release? We can add deprecation warnings in the logs and UI in the meantime though.

@alexec
Copy link
Contributor Author

alexec commented Feb 14, 2022

I actually think we can and should do this without going v4.0. The executor you use really should be an implementation detail. The emissary should have feature parity with other executors.

@terrytangyuan
Copy link
Member

Just add a note here that we will also need to remove the functionality that allows using different executors.

@terrytangyuan
Copy link
Member

terrytangyuan commented Feb 22, 2022

Some learnings from @alexec's POC for future reference: #7930 (comment)

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@terrytangyuan
Copy link
Member

Bump

@stale stale bot removed the problem/stale This has not had a response in some time label Mar 2, 2022
@alexec alexec removed the v3.5 label Mar 9, 2022
@alexec alexec closed this as completed Apr 5, 2022
@Brice187
Copy link
Contributor

Brice187 commented Nov 2, 2022

Is there a transion guide? All my workflows are affected

@terrytangyuan
Copy link
Member

@Brice187
Copy link
Contributor

Brice187 commented Nov 2, 2022

Okay, but how to fix the Workflows depending on another executor ;)

@terrytangyuan
Copy link
Member

It's a breaking change. Follow the two items related to emissary in https://github.com/argoproj/argo-workflows/blob/master/docs/upgrading.md#upgrading-to-v34

@rossigee
Copy link

rossigee commented Oct 1, 2023

I'm having some issues with the default executor image, so I've git clone'd, added some debug lines to help me narrow down the problem and built a local container. How can I request that a workflow use my debug-enhanced container?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants