Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCKER_BUILD_OPTS does not work as intended #2770

Closed
simster7 opened this issue Apr 21, 2020 · 5 comments · Fixed by #2774
Closed

DOCKER_BUILD_OPTS does not work as intended #2770

simster7 opened this issue Apr 21, 2020 · 5 comments · Fixed by #2774
Labels
type/bug

Comments

@simster7
Copy link
Member

https://github.com/argoproj/argo/blob/af9f61ea7ce53f629a284a44f0106b9ed73f24e2/Makefile#L16

When running make build in a release branch, --no-cache is not added for some reason.
@alexec
Copy link
Contributor

alexec commented Apr 21, 2020

I can tell you why DOCKER_BUILDS_OPTS != DOCKER_BUILD_OPTS (extra "S").

@alexec
Copy link
Contributor

alexec commented Apr 21, 2020

make --warn-undefined-variables does not actually help.

@simster7
Copy link
Member Author

That seems to be the error on the file as well

@alexec
Copy link
Contributor

alexec commented Apr 21, 2020

AFAIK, you cannot fail a Makefile, best you can do:

alias make=make --warn-undefined-variables

@alexec
Copy link
Contributor

alexec commented Apr 21, 2020

Just a thought. Instead of fixing, in the make clean target can you bust the Docker cache?

@simster7 simster7 mentioned this issue Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Naming error in Makefile simster7/argo
2 participants
@simster7 @alexec