Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue: Handle multiple lines #15

Closed
areYouLazy opened this issue Jun 1, 2021 · 2 comments
Closed

Issue: Handle multiple lines #15

areYouLazy opened this issue Jun 1, 2021 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@areYouLazy
Copy link
Owner

Describe the bug

Since there's no limitations in how many rows with the same IP or FQDN can be in the file, Add/Comment/Uncomment functions should not be limited to the first match

To Reproduce

    hostsFile.GetHostsFileLineByIP // returns 1 entry even if there are more lines with the same IP

Expected behavior

There should be a way to get all the lines with the same IP/FQDN
@areYouLazy areYouLazy added the bug Something isn't working label Jun 1, 2021
@areYouLazy
Copy link
Owner Author

Can be handled here? #13

Maybe add GetHostsFileLinesByIP or BulkGetHostsFileLineByIP

@areYouLazy areYouLazy added the duplicate This issue or pull request already exists label Jun 1, 2021
@areYouLazy areYouLazy mentioned this issue Jun 1, 2021
Closed
@areYouLazy
Copy link
Owner Author

Closing this, will be manged in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@areYouLazy