-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in geth and parity #171
Comments
Current balance: 0.0 ETH |
hi @izqui! I'd like to give it a try. This is my very first issue, already set up on status.im, anything else needed to get started? |
Sweet! Nothing needed to get started! |
@cpurta you are doing a wonderful job on aragon/aragon-apps#66! I'm starting with this issue today but every question that has arisen for me so far is solved in your PR :) So please feel free to take this one too once you are done, I think that your current work could be adapted to this issue very nicely. |
Are you still looking at testing this? Are you attempting to test with payments through the front end api or just straight sendtocontract calls? |
@izqui Came across this across the interwebz because we're looking do the exact same thing at Dharma. Have you found any good leads on how to do this? I'm not sure how to recreate TestRPC functionality like |
@nadavhollander That's a good question, I'm not sure if @cpurta has run into that issue with aragon/aragon-apps#66 yet... There's an open spec that's under some discussion: ethereum/interfaces#4. |
@nadavhollander I have ran into the same issue with Geth and Parity. They do not support that method in the RPC for good reason. Currently for testing you could not run any tests that make those calls when using those clients. I know that is a pretty bad solution to the problem but it may be better than the alternative. The alternative would be making changes to one/both clients to support the method and maintaining a up to date branch with the master (or releases). |
@nadavhollander Something to try (we kind of use this strategy) is avoiding use of any of the time utilities in ganache and using a mocked contract to set the time instead. |
@izqui is this bounty still open for new contributors ? If yes, I would like to work on this |
Closing; as mentioned in #186, this is not a short term priority at the moment. |
Right now the test suite only runs on ganache-cli (former testrpc). Gearing up to mainnet deployment, we need to be running our tests in real nodes where code will eventually be deployed.
Great inspiration for how to do this right can be taken from the https://github.com/JoinColony/colonySale repo
The text was updated successfully, but these errors were encountered: