Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hapi v17 Support #3

Closed
3 tasks done
timcosta opened this issue Oct 24, 2017 · 8 comments
Closed
3 tasks done

Hapi v17 Support #3

timcosta opened this issue Oct 24, 2017 · 8 comments

Comments

@timcosta
Copy link

timcosta commented Oct 24, 2017

Overview

If you are not aware yet, Hapi v17 is making the transition from callbacks to async/await, as well as deprecating some other rarely used functionality. This is a breaking change that may make your plugin no longer compatible with the Hapi API.

Changelog

Draft release notes can be found here: hapijs/hapi#3658

Target Release

The target release date for v17 is the beginning of November.

Tasks

  • Reply to this to acknowledge that you are actively maintaining this module and are willing to update it
  • Update plugin to be fully async/await compatible using the v17 branch from Hapi for testing

    Possible dev flow for updating

    • Clone Hapi
    • npm link within the Hapi repo
    • npm link hapi within your plugin repo
    • Your plugin will now be using v17 of Hapi branch for tests
  • Release new major version of your plugin on npm. Please use a major version increment as this will be a breaking change and it would be terrible for it to sneak into current versions of Hapi.

Notes

  • Support is being dropped for all versions of Node <8.0.0.
  • Hapi v16 will continue to be supported for as long as there exists a Node LTS actively being supported that is not compatible with v17.
  • Targeted release date is November 1st, 2017. Please try to have your plugin updated before then.
@ar4mirez
Copy link
Owner

@timcosta acknowledged 👍

@lironess
Copy link

lironess commented Feb 5, 2018

any updates?

@ar4mirez
Copy link
Owner

ar4mirez commented Feb 5, 2018

Working on it this morning should be good to go no later than Wednesday.

@jamesdixon
Copy link
Contributor

@ar4mirez was this ever finished? If not, I'd be more than happy to help out

@ar4mirez
Copy link
Owner

@jamesdixon Hi sorry I've been busy lately, I'll be grateful if you can give me a hand with this one :D I'm trying to also update other one also working with hapi 17. Thank you 👍

@ar4mirez
Copy link
Owner

Thanks to @jamesdixon ! 👍 this issue is now closed.

@jamesdixon
Copy link
Contributor

@ar4mirez you're welcome! thanks for creating this in the first place!

@ar4mirez
Copy link
Owner

@jamesdixon thanks :D btw I fixed the issue with v8 and v9 it was just a problem with travis-ci 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants