Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: hamburger menu #21

Closed
AntoineSoetewey opened this issue Dec 28, 2021 · 3 comments · Fixed by #23
Closed

Feature request: hamburger menu #21

AntoineSoetewey opened this issue Dec 28, 2021 · 3 comments · Fixed by #23

Comments

@AntoineSoetewey
Copy link
Contributor

AntoineSoetewey commented Dec 28, 2021 •
edited

Hello Varun,

This is not really a bug but rather a feature request.

When there are (too) many links in the menu, it is cut on the mobile version.

I managed to put the links below each other when the width of the screen is small:

Screenshot 2021-12-28 at 14 11 15

Would it be possible to add the fact that the menu becomes a hamburger menu when the width of the screen becomes small. Like this template: https://www.zerostatic.io/theme/hugo-hero/

For your information, my repo is https://github.com/AntoineSoetewey/elsaetantoine.

Thanks in advance.

Regards,
Antoine
@AntoineSoetewey AntoineSoetewey changed the title Feature: submenu or hamburger menu Feature request: hamburger menu Dec 28, 2021
@apvarun
Copy link
Owner

apvarun commented Dec 29, 2021

Hey @AntoineSoetewey, this is how the default menu layout of the theme looks.
image

I see that you have made some changes to it in your repo － header.html

It is probably the reason why the menu is weird. Can you adapt the changes based on theme's header?

@AntoineSoetewey
Copy link
Contributor Author

Thanks for your reply.

Here is how it looks like by default when there are too many links:

image

I had to make changes to header.html because the links are cut if there are too many.

Let me know if I'm not clear.

@apvarun
Copy link
Owner

apvarun commented Dec 29, 2021 •
edited

Thanks for clarifying. I'll send in a PR later for the menu 😉

@apvarun apvarun mentioned this issue Jan 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add hamburger-menu for mobile screens apvarun/blist-hugo-theme
2 participants
@apvarun @AntoineSoetewey