Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摎 Documentation: Buttons do not have sufficient contrast using Appwrite Pink [a11y][TheA11y100] #293

Open
2 tasks done
GrahamTheDevRel opened this issue Oct 26, 2023 · 10 comments
Labels
documentation Improvements or additions to documentation

Comments

@GrahamTheDevRel
Copy link

GrahamTheDevRel commented Oct 26, 2023

Issue

The Appwrite pink with white text does not have sufficient contrast (currently #FC356E to #ffffff is a contrast ratio of 3.6:1).

"Go to console" button screenshot

Why it matters

There are millions of people who have poor contrast perception, so it helps make text legible and the site easier to use.

Suggested fix

Check with Appwrite design team, but one possible fix (if unable to use a darker background colour) would be to change the button text to be 19px and bold. This would then pass as "large text" under WCAG AA.

Another option would be black text on the Appwrite Pink (doesn't look great!).

Relevant Success Criterion WCAG

Contrast (Minimum)

Additional Notes

@jasonetorres is interested in this one

Found on stream on 2023-10-25

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@GrahamTheDevRel GrahamTheDevRel added the documentation Improvements or additions to documentation label Oct 26, 2023
@jasonetorres
Copy link
Contributor

@TorstenDittmann Love to chat and get this assigned

@TGlide
Copy link
Contributor

TGlide commented Oct 30, 2023

@jasonetorres we need to check with design team beforehand. Will come back to it

@CBID2
Copy link
Contributor

CBID2 commented Oct 31, 2023

Can I work on this @jasonetorres? I haven't gotten a chance to contribute to Appwrite yet and I really want to :)

@jasonetorres
Copy link
Contributor

When @TGlide clears it for assignment you can take it @CBID2 but you owe me now muahaha

@CBID2
Copy link
Contributor

CBID2 commented Oct 31, 2023

When @TGlide clears it for assignment you can take it @CBID2 but you owe me now muahaha

Sure @jasonetorres. Any contribution you make to opensauced/pizza-verse, I'll review it! :)

@CBID2
Copy link
Contributor

CBID2 commented Dec 12, 2023

Hey @TGlide. It's been a month since this issue has been posted & no progress has been made. Can I work on it?

@jasonetorres
Copy link
Contributor

Definitely take it @CBID2 i got a bit backlogged

@CBID2
Copy link
Contributor

CBID2 commented Dec 12, 2023

Definitely take it @CBID2 i got a bit backlogged

Thanks @jasonetorres! 馃榿

@TGlide
Copy link
Contributor

TGlide commented Dec 12, 2023

@CBID2 we're still waiting for work by our design team to move on this issue :)

@CBID2
Copy link
Contributor

CBID2 commented Jan 20, 2024

Hey @TGlide! :) Any update from the design team yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants