-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📚 Documentation: respect user preferences for colour scheme. #290
Labels
documentation
Improvements or additions to documentation
Comments
@TGlide a way to achieve this could also be to set the |
Agreed, this should be a relatively simple issue to tackle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Light mode does not honour system settings. It should automatically switch the site to light mode on first visit if the person has expressed a preference for light mode.
Note: It is important that if they set a preference within the application itself that this is honoured over the preference set at system level.
For clarity:
Why it matters
Some people find dark themes distracting / harder to read. It is also a good User Experience (UX) for those who have set a user preference to have it honoured.
Suggested fix
Use JavaScript to check for the
prefers-color-scheme: light
media query on first load and assuming no cookie / local storage value has been set to indicate a local preference, set the colour scheme appropriately.If someone sets the colour scheme manually using the theme picker drop down then set preference cookie / local storage.
If cookie / local storage is set then honour that instead.
Additional Notes
Found on stream on 2023-10-25
👀 Have you spent some time to check if this issue has been raised before?
🏢 Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: