Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摎 Documentation: Social Icon Labels need improving [a11y][TheA11y100] #281

Closed
2 tasks done
GrahamTheDevRel opened this issue Oct 25, 2023 · 8 comments
Closed
2 tasks done
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@GrahamTheDevRel
Copy link

GrahamTheDevRel commented Oct 25, 2023

Issue

The icons for socials in the footer are incorrectly labelled as "Appwrite on aw-icon-discord".

Discord icon in footer highlighted with corresponding element shown in dev tools, aria-label shows "Appwrite on aw-icon-discord" instead of "Discord"

Why it matters

People navigating via assistive tech such as a screen reader or via voice control (i.e. Dragon Natural Speaking) may be confused by the label.

Suggested fix

Update the label to read as "Discord", "GitHub", "X App" etc.

Important note: Just use the name of the social, without "Appwrite". This can make navigation via voice a lot easier as they may use a command "click button discord" for example and this may not always function correctly if it starts with the text "Appwrite".

Relevant Success Criterion WCAG

Link Purpose (In Context)

Additional Notes

On stream it was mentioned that this has a fallback mechanism, so the fallback mechanism may also need updating or improving to avoid this issue in the future. Up to Appwrite to advise.

Found on stream on 2023-10-25

@jasonetorres was interested in fixing this one.

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@GrahamTheDevRel GrahamTheDevRel added the documentation Improvements or additions to documentation label Oct 25, 2023
@codingmickey
Copy link

Hey @GrahamTheDevRel! can I fix this one? Or is it already decided for @jasonetorres?

@CBID2
Copy link
Contributor

CBID2 commented Oct 26, 2023

Can I work on this issue @GrahamTheDevRel? Please? :)

@jasonetorres
Copy link
Contributor

Sorry everyone I claimed a couple I think I鈥檓 tagged in ! Plenty more up for grabs though!

@CBID2
Copy link
Contributor

CBID2 commented Oct 26, 2023

Sorry everyone I claimed a couple I think I鈥檓 tagged in ! Plenty more up for grabs though!

Ok @jasonetorres.

@TorstenDittmann TorstenDittmann added the good first issue Good for newcomers label Oct 26, 2023
@jasonetorres
Copy link
Contributor

hey @TorstenDittmann if I could get this assigned I will go ahead and make the appropriate corrections, as a fallback issue, please advise!

@Susmita-Dey
Copy link

Hey, I'd like to take up this issue.

@Arayanmemon
Copy link

@GrahamTheDevRel Can you assign this issue to me?

@TGlide
Copy link
Contributor

TGlide commented Oct 30, 2023

@jasonetorres Assigned to you 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

9 participants