Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: #5

Open
2 tasks done
theemaster opened this issue Oct 7, 2023 · 0 comments
Open
2 tasks done

🐛 Bug Report: #5

theemaster opened this issue Oct 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@theemaster
Copy link

👟 Reproduction steps

In main.js shouldn't line 60:

.join(target.fallback ?? target.default ?? '')

be targets instead of target?

I tried to create types because I am using TypeScript in my appwrite functions. My type definitions where:

interface TargetPrefs {
  appName?: string;
  appPath?: string;
  appPackage?: string;
  fallback?: string;
}

interface Targets {
  [platform: string]: string | TargetPrefs;
}

interface PathConfig {
  path: string;
  targets: Targets;
}

👍 Expected behavior

The platform definitions in the CONFIG examples do not contain an example where a target/platform contains a default property.

👎 Actual Behavior

Only targets have a property default which might be accessible.

🎲 Appwrite version

Version 1.4.x

💻 Operating system

Linux

🧱 Your Environment

appwrite 1.4.3

nodeJS using TypeScript

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@theemaster theemaster added the bug Something isn't working label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant