Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable validation for project DBs during migration #8298

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jun 20, 2024

What does this PR do?

Skip the validation so that queries that typically fail can pass. This is fine because the validation is failing on internal attributes such as an $id for cache key with * and $id for attributes that are too long because we prefix the $id with the internal database and collection id.

Test Plan

Before:

Screenshot 2024-06-20 at 3 57 12 PM

After:

Screenshot 2024-06-20 at 4 00 33 PM

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

Skip the validation so that queries that typically fail can pass. This
is fine because the validation is failing on internal attributes such
as an $id for cache key with * and $id for attributes that are too long
because we prefix the $id with the internal database and collection id.
@stnguyen90 stnguyen90 marked this pull request as ready for review June 20, 2024 23:06
@stnguyen90 stnguyen90 changed the title fix: Disable validation for project DBs during migration Disable validation for project DBs during migration Jun 20, 2024
@stnguyen90 stnguyen90 requested a review from abnegate June 20, 2024 23:45
@abnegate abnegate merged commit ba43358 into 1.5.x Jun 21, 2024
23 checks passed
@abnegate abnegate deleted the fix-migrate-validation branch June 21, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: problem migrating cache collection 🐛 Bug Report: Can't upgrade with long attributes
2 participants