Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug Report: Related VCS documents aren't deleted when a function is deleted #7018

Closed
2 tasks done
stnguyen90 opened this issue Oct 26, 2023 · 1 comment 路 Fixed by #7066
Closed
2 tasks done
Assignees
Labels
bug Something isn't working product / functions Fixes and upgrades for the Appwrite Functions.

Comments

@stnguyen90
Copy link
Contributor

馃憻 Reproduction steps

  1. Create a project
  2. Connect to GitHub
  3. Deploy a function using GitHub integration
  4. Create a PR on the function repo to create VCS comments
  5. Delete the function

馃憤 Expected behavior

All related documents such as:

  • installations
  • repositories
  • vcsComments

馃憥 Actual Behavior

These may not be deleted

馃幉 Appwrite version

Version 1.4.x

馃捇 Operating system

Linux

馃П Your Environment

No response

馃憖 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

馃彚 Have you read the Code of Conduct?

@stnguyen90 stnguyen90 added the bug Something isn't working label Oct 26, 2023
@stnguyen90 stnguyen90 added the product / functions Fixes and upgrades for the Appwrite Functions. label Oct 26, 2023
@vermakhushboo
Copy link
Member

Hey @stnguyen90, just reproduced the issue. Here is what is currently happening when we delete the function:

  1. installations collection still has the installation details: expected since deleting function shouldn't affect installation
  2. repositories collection still has the repository details: unexpected since repo is no longer linked to the Appwrite function
  3. vcsComments collection still has the comment details: unexpected since repo details should be deleted from collections
  4. functions collection doesn't have data: expected since function has now been deleted

I'm now debugging the unexpected behaviours and will be raising a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / functions Fixes and upgrades for the Appwrite Functions.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants