Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: #6982

Closed
2 tasks done
AryanParashar24 opened this issue Oct 22, 2023 · 2 comments
Closed
2 tasks done

🐛 Bug Report: #6982

AryanParashar24 opened this issue Oct 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@AryanParashar24
Copy link

AryanParashar24 commented Oct 22, 2023

Continuing the issue

🚨 Improve Appwrite Logging with New Relic Adapter #4209

👟 Reproduction steps

After making up all the files and entering all the API endpoints, secret keys, logHosts and all the access tokens form different platforms, once we get to design the tests as well when it comes to testing em all from the terminal command line with the command:

vendor/bin/phpunit

we get 4 errors as specified in the terminal as:

PHPUnit 9.6.13 by Sebastian Bergmann and contributors.

...EE.E....E                                                      12 / 12 (100%)

Time: 00:00.013, Memory: 6.00 MB

There were 4 errors:

1) LoggerTest::testAdapters
Exception: The '' DSN must contain a scheme, a host, a user and a path component.

/home/aryan2407/Hacktoberfest23/Appwrite/logger/src/Logger/Adapter/Sentry.php:49
/home/aryan2407/Hacktoberfest23/Appwrite/logger/tests/LoggerTest.php:159

2) NewRelicTest::testPush
Error: Typed property Utopia\Logger\Log::$message must not be accessed before initialization

/home/aryan2407/Hacktoberfest23/Appwrite/logger/src/Logger/Log.php:165
/home/aryan2407/Hacktoberfest23/Appwrite/logger/src/Logger/Adapter/NewRelic.php:30
/home/aryan2407/Hacktoberfest23/Appwrite/logger/src/Logger/Adapter/NewRelic.php:77
/home/aryan2407/Hacktoberfest23/Appwrite/logger/tests/e2e/Adapter/NewRelicTest.php:12

3) NewRelicTest::testSupportedEnvironments
Error: Undefined constant Utopia\Logger\Logger::ENVIRONMENT_STAGING

/home/aryan2407/Hacktoberfest23/Appwrite/logger/src/Logger/Adapter/NewRelic.php:65
/home/aryan2407/Hacktoberfest23/Appwrite/logger/tests/e2e/Adapter/NewRelicTest.php:33

4) NewRelicTest::testAdapters
Exception: The '' DSN must contain a scheme, a host, a user and a path component.

/home/aryan2407/Hacktoberfest23/Appwrite/logger/src/Logger/Adapter/Sentry.php:49
/home/aryan2407/Hacktoberfest23/Appwrite/logger/tests/LoggerTest.php:159

ERRORS!
Tests: 12, Assertions: 79, Errors: 4.

👍 Expected behavior

It should have Runed successfully after fixing all the problems in the code base or atleast should have changed the situations a bit,

👎 Actual Behavior

The output being given by the terminal didn't changed & continued to point out the same errors..

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@AryanParashar24 AryanParashar24 added the bug Something isn't working label Oct 22, 2023
@AryanParashar24
Copy link
Author

Here are the files i created which aren't able to give the result and pass the tests appwrite_NewRelic-Adapter_Logging

@stnguyen90
Copy link
Contributor

stnguyen90 commented Oct 23, 2023

@AryanParashar24, no need to create an issue for this. You can create a PR and ask questions as needed in the PR.

@stnguyen90 stnguyen90 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants