Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated error message to not user magic strings #6487

Merged
merged 9 commits into from
Oct 27, 2023
Merged

Updated error message to not user magic strings #6487

merged 9 commits into from
Oct 27, 2023

Conversation

gewenyu99
Copy link

@gewenyu99 gewenyu99 commented Oct 4, 2023 •
edited by stnguyen90
Loading

What does this PR do?

Fix use of outdated magic string.

image

Fixes #6484

Test Plan

manual

Issues

@gewenyu99 gewenyu99 mentioned this pull request Oct 5, 2023
Open
2 tasks
@stnguyen90
Copy link
Contributor

@gewenyu99 is this ready for review?

@gewenyu99
Copy link
Author

Yeah @stnguyen90

stnguyen90
stnguyen90 requested changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

Also, it's probably best to remove the package-lock.json change from this PR to avoid conflicts.

app/config/errors.php Outdated Show resolved Hide resolved
app/config/errors.php Outdated Show resolved Hide resolved
stnguyen90
stnguyen90 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just merged main into here to hopefully fix the tests.

stnguyen90
stnguyen90 requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lied 😬 Would you please remove the package-lock.json change?

@gewenyu99
Copy link
Author

@stnguyen90 Someone removed package log from main????

@gewenyu99
Copy link
Author

I was so confused trying to revert my changes haha

TorstenDittmann
TorstenDittmann approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are fine, just curious if this works for all SDK's from the ID.unique().

@christyjacob4 christyjacob4 changed the base branch from main to 1.4.x October 27, 2023 15:19
@gewenyu99
Copy link
Author

changes are fine, just curious if this works for all SDK's from the ID.unique().

I think it's consistent here!

@christyjacob4 christyjacob4 merged commit 106f4cf into 1.4.x Oct 27, 2023
3 checks passed
@christyjacob4 christyjacob4 deleted the fix-unique-in-errors branch October 27, 2023 16:13
This was referenced Nov 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: [Console] Wrong Warning Displayed
4 participants
@gewenyu99 @stnguyen90 @TorstenDittmann @christyjacob4