Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: restrict unsupported characters for project ID. #5670

Closed
2 tasks done
byawitz opened this issue Jun 6, 2023 · 7 comments · Fixed by #5743
Closed
2 tasks done

🚀 Feature: restrict unsupported characters for project ID. #5670

byawitz opened this issue Jun 6, 2023 · 7 comments · Fixed by #5743
Assignees
Milestone

Comments

@byawitz
Copy link
Member

byawitz commented Jun 6, 2023

🔖 Feature description

As of now, Appwrite's using flutter_web_auth_2 for managing OAuth2 login within any Flutter app.

This package has some limitations on what character project ID can have, as you can see here.

It will be good to have one of these.

  1. A complete restriction on what project id characters
  2. No restriction at all. But, some note that says something like so:

Be aware that Project ID cannot contain special characters if you're planning to use Flutter and OAuth2 login methods. Click here to learn more.

🎤 Pitch

This will avoid confusion in many cases, where users won't be able to debug it as there isn't any problem with Appwrite.

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@joeyouss
Copy link

joeyouss commented Jun 7, 2023

Hi
Thanks for opening this. Let me share this feedback with my team and keep this open meanwhile for community's feedback.

@gewenyu99
Copy link

gewenyu99 commented Jun 7, 2023

To be honest, I'm on board with just not allowing -, +, and ., I don't see a good reason for people to need other characters. I mean imagine the chaos of vs , because we allow special commas :P Would also reduce bugs.

@joeyouss joeyouss self-assigned this Jun 7, 2023
@byawitz
Copy link
Member Author

byawitz commented Jun 7, 2023

To be honest, I'm on board with just not allowing -, +, and ., I don't see a good reason for people to need other characters. I mean imagine the chaos of vs , because we allow special commas :P Would also reduce bugs.
;-)

That package also doesn't like uppercase characters.

@gewenyu99
Copy link

To be honest, I'm on board with just not allowing -, +, and ., I don't see a good reason for people to need other characters. I mean imagine the chaos of vs , because we allow special commas :P Would also reduce bugs.
;-)

That package also doesn't like uppercase characters.

😆 That's a little extreme, but understandable.

@byawitz
Copy link
Member Author

byawitz commented Jun 21, 2023

It looks like there's no need for restricting the upper-case letters, as Appwrite uses utf8mb4 for the charset. that will make MariaDB choose the utf8mb4_general_ci collation, so the user can just lowercase the project id.

Check this for more details: https://discord.com/channels/564160730845151244/1120835483849724036/1120908499036160090

@stnguyen90 stnguyen90 assigned stnguyen90 and unassigned joeyouss Jun 23, 2023
@stnguyen90 stnguyen90 linked a pull request Jun 23, 2023 that will close this issue
2 tasks
@joeyouss
Copy link

@byawitz we are waiting to review and merge the PR to fix this issue, once done we can close this! Thank you so much for opening this.

@byawitz
Copy link
Member Author

byawitz commented Jun 30, 2023

Cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants