Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Documentation Models Attribute Datetime #5272

Closed
2 tasks done
YaMiSt opened this issue Mar 24, 2023 · 9 comments
Closed
2 tasks done

🐛 Bug Report: Documentation Models Attribute Datetime #5272

YaMiSt opened this issue Mar 24, 2023 · 9 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers product / docs Fixes and upgrades for the Appwrite Docs.

Comments

@YaMiSt
Copy link

YaMiSt commented Mar 24, 2023

👟 Reproduction steps

Go to: https://appwrite.io/docs/models/attributeDatetime

I think the example on the website is wrong, because I got an error from appwlite cli:

{ "key": "birthDay", "type": "2020-10-15T06:38:00.000+00:00", "status": "available", "required": true, "array": false, "format": "datetime", "default": "2020-10-15T06:38:00.000+00:00" }

👍 Expected behavior

It should be (is there a format possible?):

{ "key": "birthDay", "type": "datetime", "status": "available", "required": true, "array": false, "default": "2020-10-15T06:38:00.000+00:00" }

👎 Actual Behavior

Actually i got an error from the console.

🎲 Appwrite version

Version 1.2.x

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@YaMiSt YaMiSt added the bug Something isn't working label Mar 24, 2023
@stnguyen90 stnguyen90 added the product / docs Fixes and upgrades for the Appwrite Docs. label Mar 24, 2023
@stnguyen90
Copy link
Contributor

@YaMiSt thanks for creating this issue! 🙏🏼 You are correct! It looks like the example is incorrect here:

->addRule('type', [
'type' => self::TYPE_DATETIME,
'description' => 'Attribute type.',
'default' => '',
'example' => self::TYPE_DATETIME_EXAMPLE,
])

I think the type should be self::TYPE_STRING and the example should be self::TYPE_DATETIME.

@stnguyen90 stnguyen90 added the good first issue Good for newcomers label Mar 24, 2023
@rinkuhasija
Copy link
Contributor

I want to work on this Issue. Please assign it to me.

@imtushardave
Copy link

@stnguyen90 raised PR as per the suggested changes

@stnguyen90
Copy link
Contributor

@rinkuhasija, assigned! Thanks for your interest! 🙏🏼

@imtushardave, to be considerate of others, we try to assign on a first-come, first-serve basis. If @rinkuhasija isn't able to submit a PR, I'll reassign this issue to you.

@imtushardave
Copy link

No issues @stnguyen90, I really appreciate your consideration for each contributer.

@rinkuhasija
Copy link
Contributor

@stnguyen90 raised a PR that fixes this Issue.

@imtushardave
Copy link

@stnguyen90 raised PR as per the suggested changes

I am closing this PR as @rinkuhasija has raised PR for the same. Happy contributing!

@Haimantika
Copy link
Contributor

Hi @YaMiSt are we good to close this issue? It was already addressed in this PR - #5285

@gewenyu99
Copy link

@Haimantika Closing. Thanks @rinkuhasija for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers product / docs Fixes and upgrades for the Appwrite Docs.
Projects
None yet
Development

No branches or pull requests

6 participants