🚀 Feature: Mark 40X Function Executions as Failed

[sanny-io]

🔖 Feature description

Responding to a request currently marks the execution as completed. I suggest that there be a way to signal failure in the dashboard, while also providing a response to the user.

🎤 Pitch

This gives developers the ability to give users a specific reason regarding the error that occurred, while also not misleadingly labeling an execution as successful in the dashboard.

👀 Have you spent some time to check if this issue has been raised before?

• I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

• I have read the Code of Conduct

[stnguyen90]

@sanny-io, thanks for creating this issue! 🙏🏼 This seems like a duplicate of #4594? Once this change is released, your function code can return a status 500 and the response should still be returned and include the details of your error.

[sanny-io]

Sorry, I did not see that issue, although it appears to only apply to 5xx errors. Would a pull request to include 4xx errors be ok?

[stnguyen90]

@sanny-io response and stdout should be returned for 400 errors. What is your function returning and what do you see in Appwrite?

[sanny-io]

The response is returned for 400 errors, but what I am trying to say that it does not make sense to report the function as completed in the console.

Imagine you have users reporting that your app is not working as expected (they are receiving 400 errors), but everything in the dashboard is green.

module.exports = (request, response) => {
    response.json({
        success: false,
        message: 'Error'
    }, 400)
}

In this picture, 🟢 completed should be 🔴 failed

[stnguyen90]

@sanny-io, ah I see. I'll bring this up to the team.

[stnguyen90]

@sanny-io in our next version, we'll be marking 40X errors as failed....That said, doing so will make it more difficult to differentiate between whether a function execution failed due to an error or if it was a bad request.

[sanny-io]

Bad requests are considered errors, just client ones...but I see what you mean xD

I think the tradeoff is worth it. There is no easy way to find where a problem is if everything is green, and most libraries and frameworks will report an error if they encounter 4xx, including devtools.

[gewenyu99]

@sanny-io I think we're onboard with you here. Had more talks internally. We'll try to do something to better indicate them in the future :)

Sit tight while we work on a solution with design and engineering.